btc(coin): template_other_txs decode wire — reconstructor slice 6/7 - #840
Merged
Conversation
frstrtr
force-pushed
the
btc/template-other-txs-m
branch
from
July 25, 2026 05:14
f980a99 to
3ca0892
Compare
…reconstructor other_txs (reconstructor slice 6/7) btc::coin::template_other_txs bridges TemplateCapture transactions[] to the won-block reconstructor template_other_txs_fn seam: deserialize_template_tx / deserialize_template_other_txs (template order; empty-array => coinbase-only; malformed data => throw => fail CLOSED) + make_template_other_txs_fn adapting the captured-tx provider. Decode wire only; main_btc run-loop wiring is slice 7. btc_share_test 79/79 (BtcTemplateOtherTxs 4/4), btc-tree-only.
frstrtr
force-pushed
the
btc/template-other-txs-m
branch
from
July 25, 2026 08:06
3ca0892 to
cc916ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconstructor slice 6/7.
btc::coin::template_other_txsis the decode wire betweenTemplateCapture(slice 3 / #837)transactions[]and the won-block reconstructortemplate_other_txs_fnseam (slice 5 / #839).deserialize_template_tx(data_hex)— one GBTdata(with-witness hex) -> MutableTransaction.deserialize_template_other_txs(json)—transactions[]-> txs in template order; empty/absent => empty vector (coinbase-only, the reconstructor empty contract); malformeddatathrows so the closure fails the won block CLOSED (mirrors unpack_gentx_coinbase).make_template_other_txs_fn(provider)— adapts the captured-tx provider into the seam signature; decode errors propagate => fail CLOSED.Decode wire only; wiring the concrete provider into the main_btc run-loop is slice 7. Cut off
origin/master(not stacked). btc_share_test 79/79 (BtcTemplateOtherTxs 4/4), btc-tree-only.DEP: touches src/impl/btc/test/CMakeLists.txt test-list line (same line as #837/#838/#839) — union on merge.